Skip to content

[servicefabricmanagedclusters] 2026-02-01#39563

Merged
iliu816 merged 8 commits intoAzure:mainfrom
iliu816:user/iliu/2026-02-01
Feb 24, 2026
Merged

[servicefabricmanagedclusters] 2026-02-01#39563
iliu816 merged 8 commits intoAzure:mainfrom
iliu816:user/iliu/2026-02-01

Conversation

@iliu816
Copy link
Copy Markdown
Member

@iliu816 iliu816 commented Jan 9, 2026

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@iliu816 iliu816 requested a review from a-santamaria as a code owner January 9, 2026 22:50
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 9, 2026 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added ARMReview new-api-version resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 9, 2026 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.ServiceFabric-ServiceFabricManagedClusters
TypeSpec Microsoft.ServiceFabric
Go sdk/resourcemanager/servicefabricmanagedclusters/armservicefabricmanagedclusters
JavaScript @azure/arm-servicefabricmanagedclusters
Java com.azure.resourcemanager:azure-resourcemanager-servicefabricmanagedclusters
Python azure-mgmt-servicefabricmanagedclusters

@github-actions github-actions bot added ARMAutoSignedOff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Python-Sdk and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 9, 2026
@iliu816 iliu816 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jan 12, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Feb 2, 2026
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Feb 2, 2026
@sandipsh sandipsh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 2, 2026
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 23, 2026
@iliu816 iliu816 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Feb 23, 2026
@mentat9
Copy link
Copy Markdown
Member

mentat9 commented Feb 23, 2026 •
edited
Loading

@iliu816 - I see that the no-recent-activity action must have removed the ARMSignedOff label. I'll put it back, since your PR already passed review previously.

Couple of points:

  1. Why are you waiting to merge your PR? There is no reason your spec needs to wait for the APIs to roll out.
  2. Please consider the feedback I provided for future APIs.

@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 23, 2026
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Feb 23, 2026
@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 23, 2026
@iliu816
Copy link
Copy Markdown
Member Author

iliu816 commented Feb 23, 2026

@iliu816 - I see that the no-recent-activity action must have removed the ARMSignedOff label. I'll put it back, since your PR already passed review previously.

Couple of points:

  1. Why are you waiting to merge your PR? There is no reason your spec needs to wait for the APIs to roll out.
  2. Please consider the feedback I provided for future APIs.

We were previously asked to get a review before we started planning for deployment, so we started getting the ARM review much earlier. But sometimes there may be a complication, so we usually let the PR sit until we confirm that the rollout will proceed so customers don't find documentation for the api version if it isn't available to use yet.

@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Feb 23, 2026
@github-actions github-actions bot added ARMAutoSignedOff-IncrementalTSP ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 24, 2026
@iliu816 iliu816 enabled auto-merge (squash) February 24, 2026 01:14
@iliu816 iliu816 merged commit 769257f into Azure:main Feb 24, 2026
39 of 41 checks passed
@azure-sdk azure-sdk mentioned this pull request Feb 24, 2026
Open
Copilot AI mentioned this pull request Feb 24, 2026
Draft
3 tasks
This was referenced Feb 24, 2026
Merged
Merged
Merged
Merged
Merged
nandakishores pushed a commit to nandakishores/azure-rest-api-specs that referenced this pull request Feb 26, 2026
@iliu816 @mikeharder
[servicefabricmanagedclusters] 2026-02-01 (Azure#39563)
463cc25 
* initial copy of prev api version

* 2026-02-01 init

* add new version to readme.md

* fix missed reference to previous api version

* add skipManagedNsgAssignment

* add BYOVNET to spellcheck override, fix example

* add enableResilientEphemeralOsDisk to NodeTypeProperties

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
iliu816 added a commit to Azure/azure-sdk-for-js that referenced this pull request Feb 27, 2026
@azure-sdk @iliu816
[AutoPR @azure-arm-servicefabricmanagedclusters]-generated-from-SDK G…
aad81eb 
…eneration - JS-5919238 (#37356)

Configurations:
'specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml',
API Version: 2026-02-01, SDK Release Type: stable, and CommitSHA:
'57a2504930224552a409d9435d523e631a6c93e2' in SpecRepo:
'https://github.com/Azure/azure-rest-api-specs' Pipeline run:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5919238
Refer to
https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites
to prepare for SDK release. **Release plan link:**
[https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2c8e6891-a411-f111-8406-000d3a5a7db7](https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2c8e6891-a411-f111-8406-000d3a5a7db7)
**Submitted by**: iliu@microsoft.com
## Release Plan Details
- Release Plan:
https://aka.ms/sdk-release-planner?release-plan-id=2c8e6891-a411-f111-8406-000d3a5a7db7
Spec pull request:
Azure/azure-rest-api-specs#39563
Spec API version: 2026-02-01

---------

Co-authored-by: Ivy Liu <iliu@microsoft.com>
amber-yujueWang pushed a commit to amber-yujueWang/azure-sdk-for-js that referenced this pull request Feb 27, 2026
@azure-sdk @iliu816 @amber-yujueWang
[AutoPR @azure-arm-servicefabricmanagedclusters]-generated-from-SDK G…
bfb3255 
…eneration - JS-5919238 (Azure#37356)

Configurations:
'specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml',
API Version: 2026-02-01, SDK Release Type: stable, and CommitSHA:
'57a2504930224552a409d9435d523e631a6c93e2' in SpecRepo:
'https://github.com/Azure/azure-rest-api-specs' Pipeline run:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5919238
Refer to
https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites
to prepare for SDK release. **Release plan link:**
[https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2c8e6891-a411-f111-8406-000d3a5a7db7](https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2c8e6891-a411-f111-8406-000d3a5a7db7)
**Submitted by**: iliu@microsoft.com
## Release Plan Details
- Release Plan:
https://aka.ms/sdk-release-planner?release-plan-id=2c8e6891-a411-f111-8406-000d3a5a7db7
Spec pull request:
Azure/azure-rest-api-specs#39563
Spec API version: 2026-02-01

---------

Co-authored-by: Ivy Liu <iliu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mentat9 mentat9 mentat9 left review comments

@skyiky skyiky skyiky left review comments

@a-santamaria a-santamaria a-santamaria approved these changes

Assignees

No one assigned

Labels

ARMAutoSignedOff ARMAutoSignedOff-IncrementalTSP ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@iliu816 @mentat9 @a-santamaria @skyiky @sandipsh @msyyc @mikeharder